Skip to content

Conversation

shin-
Copy link
Contributor

@shin- shin- commented Mar 30, 2016

See discussion in docker/compose#3226

Fixes #731
Fixes #706

shin- added 4 commits March 29, 2016 17:06
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
@shin- shin- force-pushed the hostname_ip_matching branch from 14a38a4 to ac3d4aa Compare March 30, 2016 00:36
@endophage
Copy link

Thank you! ssl_match_hostname.py plus tests LGTM. Can't speak to the requirements changes et al.

@shin- shin- added this to the 1.8.0 milestone Mar 30, 2016
@shin- shin- self-assigned this Mar 30, 2016
@aanand
Copy link
Contributor

aanand commented Mar 30, 2016

Does this also mean we can stop passing assert_hostname=False in Compose's docker_client.py, since the IP addresses of Machine VMs will now be correctly matched?

LGTM

@tombee
Copy link

tombee commented Mar 30, 2016

Awesome work @shin-!

@shin- shin- merged commit 8879078 into master Mar 30, 2016
@FiloSottile
Copy link

This seems not to work for me on OS X.

https://gist.github.com/FiloSottile/d308789cc7a8f1de8f36a127ecfbff19

The version is 1.8.0, the CLI works, the certificate has the IP on it, but it still raises requests.exceptions.SSLError: hostname '192.168.64.6' doesn't match 'localhost'

@FiloSottile
Copy link

Interestingly, patching the function to print the certificate yields

{'subjectAltName': [('DNS', 'localhost')], 'subject': ((('commonName', None),),)}

so it's a parsing problem, not a matching one. I'll open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants