Added extra filtering options to containers command in ClientAPI

[SakuraSound]

From #1016, I added some extra documentation notes for the containers command in ClientAPI.
Signed-off-by: Joir-dan Gumbs jdagumbs@gmail.com

[shin-]

Thanks! Do you mind rebasing this against the current master? Changes LGTM.

[SakuraSound]

Done

[MHBauer]

Looks more comprehensive. I see a filter for volume and isolation in the docker docs. Given windows isn't prime time yet, I think you could leave isolation off, but I'd like to see volume included.

[shin-]

Thanks!
If we expect this list will continue to grow, maybe a better solution would be to link to the source instead of trying to play catch up. Or at least add a disclaimer like "A comprehensive list is available [here](link-docker-docs)"

[SakuraSound]

I could probably add that at the bottom of the updated docs, and it should work as long as the link carries with each new version.

[shin-]

Ah, yeah, fair point. I don't think the docker docs have a dynamic link to the latest API docs page. Maybe we can just link to https://docs.docker.com/engine/reference/api/docker_remote_api/ for now.

[SakuraSound]

Looking at the docs link, it seems we may be able to get away with using links:

https://docs.docker.com/engine/reference/commandline/ps/ seems like it carries across versions.

[shin-]

Agreed. Do you mind making the change?

[SakuraSound]

Can do

Sent from my iPhone

On Apr 19, 2016, at 17:17, Joffrey F notifications@github.com wrote:

Agreed. Do you mind making the change?

―
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub

[shin-]

Awesome, thank you!