Skip to content

Conversation

bboreham
Copy link
Contributor

Fixes #1047.

It's not entirely satisfactory, as it relies on the cleanup working in a particular way. However client.create_network() does not return the ID cleanly in the previous call (it returns something like {"u'Warning': u'Network with name dockerpy845377 (id : 3d8a876ff38eaa6df14d37a40922046b1274fb685c5cf25abfe71c94531e1c41) already exists', u'Id': u'4cf5bbce6cb471730fbd962c5391392c3708dc4bfc3b720ec44c047c38e2f5ef'"})

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "remove-network" git@github.com:bboreham/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

1 similar comment
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "remove-network" git@github.com:bboreham/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@bboreham
Copy link
Contributor Author

@GordonTheTurtle it's signed now.

@shin-
Copy link
Contributor

shin- commented Apr 26, 2016

Thanks, LGTM!

Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
@bboreham
Copy link
Contributor Author

I'm not sure what your bot didn't like about my signature, but evidently re-signing it made it happy.

Have also re-based against master.

@shin-
Copy link
Contributor

shin- commented Sep 10, 2016

Ah, sorry I lost track of this, but I actually included that fix in #1178 . Thanks again for your help tracking this down!

@shin- shin- closed this Sep 10, 2016
@shin- shin- added this to the 1.10.0 milestone Sep 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants