support Python 3.5 #1071
Merged
support Python 3.5 #1071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
support-py35
branch
2 times, most recently
from
3621f99 to
7cb84c2
Compare
Signed-off-by: Thomas Grainger <tom.grainger@procensus.com>
Signed-off-by: Thomas Grainger <tom.grainger@procensus.com>
|
Please sign your commits following these rules: $ git clone -b "support-py35" git@github.com:graingert/docker-py.git somewhere
$ cd somewhere
$ git rebase -i HEAD~3
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: Thomas Grainger <tom.grainger@procensus.com>
| return delta.seconds + delta.days * 24 * 3600 | ||
|
|
||
|
|
||
| def longint(n): |
There was a problem hiding this comment.
all this does is allow users to enter their storage size in pounds (300lb) on python 2
|
@dnephin any update on a merge? |
|
I thought I had commented on there, sorry. Changes LGTM. |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.