Skip to content

Conversation

kanaka
Copy link
Contributor

@kanaka kanaka commented Sep 2, 2016

any() expects a single collection argument, not a list of arguments.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:kanaka/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/docker/docker/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:kanaka/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Ammending updates the existing PR. You DO NOT need to open a new one.

any() expects a single collection argument, not a list of arguments.

Signed-off-by: Joel Martin <github@martintribe.org>
@shin-
Copy link
Contributor

shin- commented Sep 2, 2016

Oops. 😞

LGTM - thanks!

@shin- shin- merged commit fff71e9 into docker:master Sep 2, 2016
@shin- shin- added this to the 1.10.0 milestone Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants