Add credentials store support #1181
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-
force-pushed
the
credstore-support
branch
from
21c0404 to
240cf33
Compare
|
Fixes #1023 |
docker/auth/auth.py
Outdated
| return res | ||
| except dockerpycreds.StoreError as e: | ||
| log.error('Credentials store error: {0}'.format(repr(e))) | ||
|
|
There was a problem hiding this comment.
I wonder if this should raise an exception? The user explicitly asked to use the credential store, right ?
There was a problem hiding this comment.
Yeah, I need to differentiate a runtime error from a missing entry in dockerpycreds, then we can raise when there's an issue, and proceed with an unauthenticated push/pull if we just don't have credentials.
|
LGTM, just one comment. I'm not all that familiar with these credential stores, but the code looks good to me. |
Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
credstore-support
branch
from
0083bfd to
219a869
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.