Skip to content

Add .PHONY for each makefile instruction #1191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Add .PHONY for each makefile instruction #1191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,47 @@
.PHONY: all build test integration-test unit-test build-py3 unit-test-py3 integration-test-py3

.PHONY: all
all: test

.PHONY: clean
clean:
-docker rm -vf dpy-dind
find -name "__pycache__" | xargs rm -rf

.PHONY: build
build:
docker build -t docker-py .

.PHONY: build-py3
build-py3:
docker build -t docker-py3 -f Dockerfile-py3 .

.PHONY: build-docs
build-docs:
docker build -t docker-py-docs -f Dockerfile-docs .

.PHONY: build-dind-certs
build-dind-certs:
docker build -t dpy-dind-certs -f tests/Dockerfile-dind-certs .

.PHONY: test
test: flake8 unit-test unit-test-py3 integration-dind integration-dind-ssl

.PHONY: unit-test
unit-test: build
docker run docker-py py.test tests/unit

.PHONY: unit-test-py3
unit-test-py3: build-py3
docker run docker-py3 py.test tests/unit

.PHONY: integration-test
integration-test: build
docker run -v /var/run/docker.sock:/var/run/docker.sock docker-py py.test tests/integration

.PHONY: integration-test-py3
integration-test-py3: build-py3
docker run -v /var/run/docker.sock:/var/run/docker.sock docker-py3 py.test tests/integration

.PHONY: integration-dind
integration-dind: build build-py3
docker rm -vf dpy-dind || :
docker run -d --name dpy-dind --privileged dockerswarm/dind:1.12.0 docker daemon\
Expand All @@ -42,6 +52,7 @@ integration-dind: build build-py3
py.test tests/integration
docker rm -vf dpy-dind

.PHONY: integration-dind-ssl
integration-dind-ssl: build-dind-certs build build-py3
docker run -d --name dpy-dind-certs dpy-dind-certs
docker run -d --env="DOCKER_HOST=tcp://localhost:2375" --env="DOCKER_TLS_VERIFY=1"\
Expand All @@ -57,8 +68,10 @@ integration-dind-ssl: build-dind-certs build build-py3
--link=dpy-dind-ssl:docker docker-py3 py.test tests/integration
docker rm -vf dpy-dind-ssl dpy-dind-certs

.PHONY: flake8
flake8: build
docker run docker-py flake8 docker tests

.PHONY: docs
docs: build-docs
docker run -v `pwd`/docs:/home/docker-py/docs/ -p 8000:8000 docker-py-docs mkdocs serve -a 0.0.0.0:8000