Do not traverse excluded directories that are not prefixes of dockerignore exceptions. #1277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A test would be great |
|
I should be able to add some unit tests for the should_check_directory function this evening. |
|
I added some unit tests for the new The overall behavior of processing |
… exceptions Fixes an issue where all files in a rather large excluded folder are traversed and examined when creating the build context for potential exception to the exclusion, even though the exclusion rule is for a completely unrelated folder. Signed-off-by: Brandon Bodnar <bodnarbm@gmail.com>
Signed-off-by: Brandon Bodnar <bodnarbm@gmail.com>
|
LGTM Thanks! |
bodnarbm
deleted the
do-not-traverse-ignored-directories-with-no-potential-exceptions
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1276.
Updates the algorithm implemented in #863 to not traverse down into excluded directories if their path is not a prefix for some .dockerignore exception.
I believe this change conforms with the current handling for dockerignore exceptions by docker itself.
Signed-off-by: Brandon Bodnar bodnarbm@gmail.com