Adds a few model properties #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shin- do these features have a chance of getting merged somehow? |
Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
The Docker API seems to respond with a 'null' value for the 'Labels' attribute from containers that were created with older Docker versions. An empty dictionary is returned in this case. Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
Signed-off-by: Frank Sachsenheim <funkyfuture@riseup.net>
|
Yes, those are pretty useful additions. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds the properties
imageandlabelsfor container objects, andlabelsfor image objects. this would solve #1369 in a way.alongside is a patch that made a docs build result actually available outside the container.