Skip to content

Conversation

mbelang
Copy link

@mbelang mbelang commented Aug 24, 2017

Since the docker CLI adds a default listen address (0.0.0.0:2377)
when joining a node to the swarm, the docker-py api will support
the same behavior.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "join-swarn-default-listen-address" git@github.com:mbelang/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@mbelang mbelang force-pushed the join-swarn-default-listen-address branch from ed7df64 to bdec585 Compare August 24, 2017 20:24
@mbelang mbelang force-pushed the join-swarn-default-listen-address branch from bdec585 to e33d61f Compare August 24, 2017 20:26
@mbelang
Copy link
Author

mbelang commented Aug 24, 2017

Build failed, don't know why, I didn't touch that part of the code.
Here is the error:

20:33:19 [py2.7_1.13.1] =================================== FAILURES ===================================
20:33:19 [py2.7_1.13.1] ________________________ PluginTest.test_enable_plugin _________________________
20:33:19 [py2.7_1.13.1] tests/integration/api_plugin_test.py:49: in test_enable_plugin
20:33:19 [py2.7_1.13.1]     assert self.client.enable_plugin(SSHFS)
20:33:19 [py2.7_1.13.1] docker/utils/decorators.py:34: in wrapper
20:33:19 [py2.7_1.13.1]     return f(self, *args, **kwargs)
20:33:19 [py2.7_1.13.1] docker/api/plugin.py:85: in enable_plugin
20:33:19 [py2.7_1.13.1]     self._raise_for_status(res)
20:33:19 [py2.7_1.13.1] docker/api/client.py:222: in _raise_for_status
20:33:19 [py2.7_1.13.1]     raise create_api_error_from_http_exception(e)
20:33:19 [py2.7_1.13.1] docker/errors.py:31: in create_api_error_from_http_exception
20:33:19 [py2.7_1.13.1]     raise cls(e, response=response, explanation=explanation)
20:33:19 [py2.7_1.13.1] E   APIError: 500 Server Error: Internal Server Error ("error setting up propagated mount dir: invalid argument")
20:33:19 [py2.7_1.13.1] === 1 failed, 250 passed, 10 skipped, 2 xfailed, 1 xpassed in 328.52 seconds ===

If somebody could help me understand the nature of the problem, it would be appreciated.

Since the docker CLI adds a default listen address (0.0.0.0:2377)
when joining a node to the swarm, the docker-py api will support
the same behavior to easy configuration.

Signed-off-by: Maxime Belanger <maxime.b.belanger@gmail.com>
@mbelang mbelang force-pushed the join-swarn-default-listen-address branch from e33d61f to 7fa2cb7 Compare August 29, 2017 12:39
@mbelang
Copy link
Author

mbelang commented Aug 29, 2017

Hum I guess a test is/was flaky, rerunning without any change: All green!

@shin- shin- added this to the 2.7.0 milestone Dec 19, 2017
@shin- shin- merged commit ac68a36 into docker:master Dec 19, 2017
@shin-
Copy link
Contributor

shin- commented Dec 19, 2017

Thank you - and sorry for the late review!

@mbelang
Copy link
Author

mbelang commented Dec 19, 2017

no worries :)

@mbelang mbelang deleted the join-swarn-default-listen-address branch December 19, 2017 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants