Require at least requests v2.14.2 to update old chardet #1789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docker-py
is having trouble withrequests<2.14
because it may use an old version ofchardet
. Some new function is used that does not exist in older versions of the dependency, causing it to crash in some cases.When using
docker-py
with Ansible, using modules likedocker_network
result in an error with old versions ofchardet
installed. These errors are resolved when usingchardet>=3.0
.requests
now requires this version since 2.14.This problem would only happen if an earlier version of
requests
was already installed by some other package, where the version was still satisfied by the currentdocker-py
configuration and was below 2.14. When the dependency is freshly installed, this problem would not occur as a version higher than 2.14 would be chosen.It could be manually fixed by installing
chardet>=3.0.1
in the command line using pip, but this is of course not desired.Therefore I've changed the configuration to require at least
requests>=2.14.2
(where the patch version.2
fixed some bugs) to fix this issue as a whole.