Fix #1381: Add exit code to exec_run #1797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnq90
force-pushed
the
add_exit_code_to_exec_run
branch
from
21fda2f to
1adb268
Compare
hnq90
force-pushed
the
add_exit_code_to_exec_run
branch
from
1adb268 to
4f5a1f0
Compare
Signed-off-by: HuyNQ <huy@huynq.net>
hnq90
force-pushed
the
add_exit_code_to_exec_run
branch
from
4f5a1f0 to
436306f
Compare
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1381, we need to get the exit code after executing a command by
exec_run.So I change the returning of
exec_runto return a dictionary which hasoutputandexit_code.Please help me to review this PR. Thank you in advance.