Remove test_update_swarm_name #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
commented
Nov 11, 2017
tests/integration/api_swarm_test.py
Outdated
|
|
||
| @requires_api_version('1.24') | ||
| def test_update_swarm_name(self): | ||
| assert self.init_swarm() |
There was a problem hiding this comment.
hm, perhaps this test should be removed altogether if this is testing that the name can be updated (let me know if it should)
There was a problem hiding this comment.
Yup, test should be removed altogether if naming isn't supported.
There was a problem hiding this comment.
I'll update the PR, thanks!
thaJeztah
force-pushed
the
fix-swarm-update-test
branch
2 times, most recently
from
56f7fda to
6f9a342
Compare
Docker currently only supports the "default" cluster in Swarm-mode, and an upcoming SwarmKit release will produce an error if the name of the cluster is updated, causing the test to fail. Given that renaming the cluster is not supported, this patch removes the test Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
thaJeztah
force-pushed
the
fix-swarm-update-test
branch
from
6f9a342 to
e6cc3c1
Compare
thaJeztah
changed the title
|
Updated; now removed the test instead |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker currently only supports the "default" cluster in Swarm-mode. This test used a different name for the cluster, which will produce an error, causing the test to fail;
relates to moby/moby#35464 / moby/swarmkit#2436
ping @shin-