Fetch network details with network lists greedily

[rycus86]

This change would fix #1775 plus adds some missing documentation and input arguments around networks.

Per the comment on #1775 (comment) this change enables adding a greedy=True parameter on the model's and the API client's network list function that will inspect each network on the initial list.

[shin-]

Thanks, that's definitely a useful feature to have.

My only issue with it as it stands is that I don't think the greedy flag belongs in the APIClient. Advanced, usability-minded functionality belongs in DockerClient instead. APIClient should be as lean and resource-efficient as possible.

[thaJeztah]

Note that using API 1.25 will still return the container details; see https://github.com/moby/moby/pulls/30673

The list of containers was removed from the network list because it can be a heavy operation in larger setups (many containers, many networks), (inspecting a single network still returns attached containers)

[rycus86]

Thanks for having a look at this!

I've moved the new flag to the model only and left the API client unchanged. I only added it there because of #1775 (comment) but it makes sense to leave the API client as it was.

@thaJeztah thanks for letting me know!
It looks like the behavior has changed in API 1.28, added a check for it and won't inspect the services if the client is on a lower version.

[rycus86]

Hi @shin- ,

Sorry I haven't done reviews on GitHub yet, is there a link/button somewhere to update that I've made the changes that were requested?

Thank you!

[shin-]

@rycus86 I saw your changes, just didn't have time to take a closer look yet with Thanksgiving break and other priorities. Thank you for your patience. 👍

[rycus86]

Right, sorry, forgot about Thanksgiving! :)
Enjoy your break!

[shin-]

LGTM, thank you!