Skip to content

Conversation

asottile
Copy link
Contributor

@asottile asottile commented Dec 7, 2017

No description provided.

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:asottile/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@asottile
Copy link
Contributor Author

asottile commented Dec 7, 2017

ugh right, github editor doesn't sign commits

Signed-off-by: Anthony Sottile <asottile@umich.edu>
@shin-
Copy link
Contributor

shin- commented Dec 7, 2017

Thanks!

@shin- shin- merged commit b4eb3b9 into docker:master Dec 7, 2017
@asottile asottile deleted the patch-1 branch December 7, 2017 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants