-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Added scale method to the Service model. #1846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,6 +4,8 @@ | |
|
||
from .. import helpers | ||
from .base import TEST_API_VERSION | ||
from docker.errors import InvalidArgument | ||
from docker.types.services import ServiceMode | ||
|
||
|
||
class ServiceTest(unittest.TestCase): | ||
|
@@ -203,6 +205,50 @@ def test_scale_service(self): | |
spec = service.attrs['Spec']['TaskTemplate']['ContainerSpec'] | ||
assert spec.get('Command') == ['sleep', '300'] | ||
|
||
def test_scale_method_service(self): | ||
client = docker.from_env(version=TEST_API_VERSION) | ||
service = client.services.create( | ||
# create arguments | ||
name=helpers.random_name(), | ||
# ContainerSpec arguments | ||
image="alpine", | ||
command="sleep 300", | ||
) | ||
tasks = [] | ||
while len(tasks) == 0: | ||
tasks = service.tasks() | ||
assert len(tasks) == 1 | ||
service.scale(2) | ||
while len(tasks) == 1: | ||
tasks = service.tasks() | ||
assert len(tasks) >= 2 | ||
# check that the container spec is not overridden with None | ||
service.reload() | ||
spec = service.attrs['Spec']['TaskTemplate']['ContainerSpec'] | ||
assert spec.get('Command') == ['sleep', '300'] | ||
|
||
def test_scale_method_global_service(self): | ||
client = docker.from_env(version=TEST_API_VERSION) | ||
mode = ServiceMode('global') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It looks like the default value is |
||
service = client.services.create( | ||
name=helpers.random_name(), | ||
image="alpine", | ||
command="sleep 300", | ||
mode=mode | ||
) | ||
tasks = [] | ||
while len(tasks) == 0: | ||
tasks = service.tasks() | ||
assert len(tasks) == 1 | ||
with self.assertRaises(InvalidArgument, | ||
msg='Cannot scale a global container'): | ||
service.scale(2) | ||
|
||
assert len(tasks) == 1 | ||
service.reload() | ||
spec = service.attrs['Spec']['TaskTemplate']['ContainerSpec'] | ||
assert spec.get('Command') == ['sleep', '300'] | ||
|
||
@helpers.requires_api_version('1.25') | ||
def test_restart_service(self): | ||
client = docker.from_env(version=TEST_API_VERSION) | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is failing because the default
mode
for a service isglobal
. Make sure to set the initial mode toreplicated
!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @shin-. I already changed.