add ports to containers #1882
Merged
add ports to containers #1882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "1743-container-ports" git@github.com:larkost/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
larkost
force-pushed
the
1743-container-ports
branch
from
9bbfb42 to
da8c196
Compare
larkost
force-pushed
the
1743-container-ports
branch
from
da8c196 to
546c82a
Compare
|
Just in case... this was signed 19 days ago. |
|
@TomasTomecek Could you please respond to my responses? This PR is getting a bit stale. |
|
I'm not a maintainer of this project, my comments are pretty much just my opinions. For a proper code review you need to wait for @shin- |
|
Hey @shin- any update on this PR? |
ulyssessouza
previously requested changes
Mar 15, 2019
|
@larkost @ulyssessouza Any progress on this PR? It has been a year and this is super sensible and useful. Hope this can be merged. |
Signed-off-by: Karl Kuehn <kuehn.karl@gmail.com>
Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
ulyssessouza
force-pushed
the
1743-container-ports
branch
from
546c82a to
d1f7979
Compare
|
Great! Happy to see this is finally merged! Thanks guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
portsproperty to theContainerobject to list currently forwarded ports.This should be the answer to #1742