Skip to content

Rename name parameter in pull method to repository #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2018
Merged

Rename name parameter in pull method to repository #1889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions docker/models/images.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ def load(self, data):

return [self.get(i) for i in images]

def pull(self, name, tag=None, **kwargs):
def pull(self, repository, tag=None, **kwargs):
"""
Pull an image of the given name and return it. Similar to the
``docker pull`` command.
Expand All @@ -280,7 +280,6 @@ def pull(self, name, tag=None, **kwargs):
Args:
name (str): The repository to pull
tag (str): The tag to pull
insecure_registry (bool): Use an insecure registry
auth_config (dict): Override the credentials that
:py:meth:`~docker.client.DockerClient.login` has set for
this request. ``auth_config`` should contain the ``username``
Expand All @@ -305,12 +304,12 @@ def pull(self, name, tag=None, **kwargs):
>>> images = client.images.pull('busybox')
"""
if not tag:
name, tag = parse_repository_tag(name)
repository, tag = parse_repository_tag(repository)

self.client.api.pull(name, tag=tag, **kwargs)
self.client.api.pull(repository, tag=tag, **kwargs)
if tag:
return self.get('{0}:{1}'.format(name, tag))
return self.list(name)
return self.get('{0}:{1}'.format(repository, tag))
return self.list(repository)

def push(self, repository, tag=None, **kwargs):
return self.client.api.push(repository, tag=tag, **kwargs)
Expand Down