Add chunk_size parameter to data downloading methods #1906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shin-
force-pushed
the
1352-data_stream_control
branch
from
bfc6547 to
8ebb0b9
Compare
|
LGTM. That should solve all our problems with v3. What is the release circle of this patch? |
goldmann
approved these changes
Feb 14, 2018
|
Thanks for updating! (´ω｀) All codes LGTM. The only thing i'm concerned about is the comment at line https://github.com/docker/docker-py/pull/1906/files#diff-b5bb91e2b94da86ea05c1fe77a6ff432R354 should be updated now. We not only use this method to attach to a TTY but also used in more case now. |
…hive, save) Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
1352-data_stream_control
branch
from
8ebb0b9 to
581ccc9
Compare
|
@pvizeli It's not set in stone, but most likely 3.1.0 should come out late February or early March |
|
Would it make sense to cut 3.0.2 soon-ish? |
|
I think also that need go into a hotfix. Actual it make every image/file handling unusable |
|
3.1.0 is out with the fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1352
cc @david-drinn @realityone @goldmann Feedback appreciated!