Support using proxy values from config #2219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
the _cfg attribute does not exist anymore Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
This reverts commit 7584e5d. Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
This is to avoid a breaking change Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
Signed-off-by: Corentin Henry <corentinhenry@gmail.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
|
Awesome, thank you very much @shin-, and sorry for not pushing that past the finish line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased and updated #2202
Fixes #2199
cc @little-dude - we're planning to do a release tomorrow so I wanted to get that in before then. Thanks so much for all the work you've done to get that working!