Skip to content

Add registry auth header to inspect_distribution requests #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2019
Merged

Add registry auth header to inspect_distribution requests #2227

merged 1 commit into from
Mar 26, 2019

Conversation

shin-
Copy link
Contributor

@shin- shin- commented Jan 12, 2019

Update docstring for auth_config parameter in pull, push, and
inspect_distribution

Fixes #2225

@shin-
Add registry auth header to inspect_distribution requests
b6f6e72 
Update docstring for auth_config parameter in pull, push, and
inspect_distribution

Signed-off-by: Joffrey F <joffrey@docker.com>
@shin- shin- added this to the 4.0.0 milestone Jan 12, 2019
@Mattrack Mattrack mentioned this pull request Jan 31, 2019
Closed
@hannseman hannseman mentioned this pull request Mar 18, 2019
Closed
@shin- shin- requested a review from ulyssessouza March 23, 2019 20:46
ulyssessouza
ulyssessouza approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @shin- !

ijc
ijc approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@ijc ijc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. I guess this is a tricky one to arrange a test for.

@ijc ijc merged commit 02e660d into master Mar 26, 2019
@shin- shin- deleted the 2225-inspect_distrib_auth branch May 1, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ulyssessouza ulyssessouza ulyssessouza approved these changes

@ijc ijc ijc approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shin- @ulyssessouza @ijc