Skip to content

Conversation

arcenik
Copy link

@arcenik arcenik commented Feb 24, 2019

This is a fix proposal for #2248.

It adds a build_response function on the SSHAdapter object to close the ssh channel oncy the response is received.

Is there a more elegant way to make requests do it ?

The versions are

  • python-docker 3.7.0-1
  • docker 18.09.2-ce (on Archlinux)
  • Python 3.7.2

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix/ssh-channel-not-closed" git@github.com:arcenik/docker-py.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@arcenik arcenik force-pushed the fix/ssh-channel-not-closed branch from ed3268c to cd578dd Compare February 24, 2019 15:32
Signed-off-by: François Scala <guthub@arcenik.net>
@jcsirot
Copy link
Contributor

jcsirot commented Feb 27, 2019

@arcenik Thank you for your PR. However we are currently working on a patch globally improving the SSH support, including a fix for #2248

@jcsirot jcsirot closed this Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants