Fix base_url to keep TCP protocol #2292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyssessouza
force-pushed
the
fix-config-proxy-mapping
branch
4 times, most recently
from
63ef35c to
b0310b1
Compare
added 2 commits
March 26, 2019 16:04
This test is quite flaky on ssl integration test Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
This fix lets the responsability of changing the protocol to `parse_host` afterwards, letting `base_url` with the original value. Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
ulyssessouza
force-pushed
the
fix-config-proxy-mapping
branch
from
b0310b1 to
b2175c9
Compare
rumpl
approved these changes
Mar 27, 2019
ulyssessouza
commented
Mar 27, 2019
| class PortTest(BaseAPIIntegrationTest): | ||
| def test_port(self): | ||
|
|
||
| port_bindings = { |
There was a problem hiding this comment.
That was an autoformat from my IDE. I can remove if you would like
shin-
approved these changes
Mar 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix lets the responsability of changing the
protocol to
parse_hostafterwards, lettingbase_urlwith the original value.This issue causes docker/compose#6551