Add support for setting init on services #2297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijc
approved these changes
Mar 28, 2019
There was a problem hiding this comment.
LGTM. I also wasn't able to definitively pin down the API version, but 1.38 is the conservative choice.
moby/moby@e401b88 seems to be the commit which added it, and at the point in time api/common.go said 1.38
Signed-off-by: Hannes Ljungberg <hannes@5monkeys.se>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for setting the boolean
InitinContainerSpecwhen creating and updating services.I'm not really sure about what API version this feature was actually introduced.
https://docs.docker.com/engine/reference/commandline/service_create/ states that
--initis supported from 1.37. But when comparing the API spec it looks like it was supported in 1.38.Check
TaskTemplate.ContainerSpec.Init:https://docs.docker.com/engine/api/v1.38/#operation/ServiceCreate
vs
https://docs.docker.com/engine/api/v1.37/#operation/ServiceCreate
I've set the minimum version to 1.38.
Fixes #2293