Handle str in setter for test on HealthCheck
#2353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kajetan Champlewski <contact@kajetan.ch>
Signed-off-by: Kajetan Champlewski <contact@kajetan.ch>
trickeydan
approved these changes
May 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When HealthCheck is instantiated, the
testparameter can be astr, which is turned into the the list["CMD-SHELL", test].This PR adds the same functionality to the setter for
test, so that the effect for passing astrto the setter is the same as instantiating HealthCheck with astrfortest.This PR also cleans up the documentation on HealthCheck, fixing a typo and sticking to the python standard of
intas opposed tointeger.