Update to python 3.7 (buster) and use build-args #2379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
changed the title
|
Removed the multi-stage commits; this now only bumps to Python 3.7 and adds the build-args |
|
credential-helper tests failing https://jenkins.dockerproject.org/job/docker/job/docker-py/job/PR-2379/2/execution/node/125/log/ |
|
Looking if the output format changed between Jessie and Buster This is the output in Buster; Which will produce this after grep'ing; Looks like that might be the problem |
|
On Jessie; It does the right thing; So, yes, that looks to be the problem |
|
This looks to do the job; updating gpg2 --no-auto-check-trustdb --list-secret-key | awk '/^sec/{getline; $1=$1; print}'
9781B87DAB042E6FD51388A5464ED987A7B21401 |
The build arg can be used to either test different versions, but
also makes it easier to "grep" when upgrading versions.
The output format of `gpg2 --list-secret-keys` changed in the version
installed on Buster, so `grep` was replaced with `awk` to address
the new output format;
Debian Jessie:
gpg2 --no-auto-check-trustdb --list-secret-keys
/root/.gnupg/secring.gpg
------------------------
sec 1024D/A7B21401 2018-04-25
uid Sakuya Izayoi <sakuya@gensokyo.jp>
ssb 1024g/C235E4CE 2018-04-25
Debian Buster:
gpg2 --no-auto-check-trustdb --list-secret-keys
/root/.gnupg/pubring.kbx
------------------------
sec dsa1024 2018-04-25 [SCA]
9781B87DAB042E6FD51388A5464ED987A7B21401
uid [ultimate] Sakuya Izayoi <sakuya@gensokyo.jp>
ssb elg1024 2018-04-25 [E]
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
Hm... now Jenkins didn't run 😞 |
|
Triggered it manually 🤷♂ |
|
Seeing two failures locally; looks like it may be a wrong assumption in the test; docker build --platform=foobar -<<EOF
FROM busybox
EOF
Error response from daemon: "foobar": unknown operating system or architecture: invalid argument
docker pull --platform=foobar hello-world:latest
Error response from daemon: "foobar": unknown operating system or architecture: invalid argumentOk; looks like the On Docker 18.09.7 Actually; same issue on Docker 19.03.0-rc3; Looks like the containerd error isn't converted into the correct status code. |
|
Docker 18.03 returns a different string, but also looks to be returning a 500 for the The |
|
opened #2382 to address the "experimental" tests ping @shin- @ulyssessouza PTAL |
| @@ -1,5 +1,6 @@ | |||
| ARG PYTHON_VERSION=3.6 | |||
| FROM python:$PYTHON_VERSION-jessie | |||
| ARG PYTHON_VERSION=3.7 | |||
There was a problem hiding this comment.
Shouldn't it be ARG PYTHON_VERSION=3.7-stretch to keep the same level of specificity in the TAG?
Or that removal was intentional?
There was a problem hiding this comment.
They're aliases. Removing it allows overriding it with PYTHON_VERSION=3.6-jessie although that would now fail because of the gpg2 change.
Not sure if there was a specific reason to add the -jessie suffix; I couldn't find one directly
There was a problem hiding this comment.
Hmmm.. checking here, It's not exactly the same image:
REPOSITORY TAG IMAGE ID CREATED SIZE
python 3.7-stretch 71c6ddda7cab 2 days ago 941MB
python 3.7 42d620af35be 2 days ago 918MB
I'm not against changing to 3.7 instead of 3.7-stretch.
My point is just that we have to know it's a different image.
There was a problem hiding this comment.
Did you check the image's digest as well? Was your image cache out of date perhaps?
docker manifest inspect python:3.7
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 2217,
"digest": "sha256:11454cd111137f54f2c91a624ab16b88d6dd31092a6f7fa267dea5e21b9f0a77",
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
docker manifest inspect python:3.7-buster
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 2217,
"digest": "sha256:11454cd111137f54f2c91a624ab16b88d6dd31092a6f7fa267dea5e21b9f0a77",
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
docker manifest inspect python:3.7.4
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 2217,
"digest": "sha256:11454cd111137f54f2c91a624ab16b88d6dd31092a6f7fa267dea5e21b9f0a77",
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
docker manifest inspect python:3.7.4-buster
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 2217,
"digest": "sha256:11454cd111137f54f2c91a624ab16b88d6dd31092a6f7fa267dea5e21b9f0a77",
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
There was a problem hiding this comment.
Just removed all my images and docker pull python:3.7 and docker pull python:3.7-stretch. By the way, I don't see python:3.7-stretch in your message.
My inspect on python:3.7-stretch results in:
$ docker manifest inspect python:3.7-stretch
{
"schemaVersion": 2,
"mediaType": "application/vnd.docker.distribution.manifest.list.v2+json",
"manifests": [
{
"mediaType": "application/vnd.docker.distribution.manifest.v2+json",
"size": 2218,
"digest": "sha256:4cb0e5e9861fad660bbe72f0ae5a35e982daad0b7106612aa8ee4c9277faa7d6",
"platform": {
"architecture": "amd64",
"os": "linux"
}
},
...
There was a problem hiding this comment.
oh! 🤦♂ now see you're comparing with -stretch, but 3.7 is equivalent to -buster (which is current stable)
There was a problem hiding this comment.
Ahhh... Ok! I didn't know about buster (since it was released July 6th, 2019). In my head stretch was still the current stable. Sorry for that 🤦♂️
In this case, YES! You are right! I drop my charges 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build arg can be used to either test different versions, but also makes it easier to "grep" when upgrading versions.
The output format of
gpg2 --list-secret-keyschanged in the version installed on Buster, sogrepwas replaced withawkto address the new output format;Debian Jessie:
Debian Buster:
Follow-up to #2377 and #2378 (first two commits are from those PR's)