Skip to content

Fix memory conversion to bytes #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 17, 2020
Merged

Fix memory conversion to bytes #2645

merged 2 commits into from
Aug 17, 2020

Conversation

aiordache
Copy link
Contributor

Fix conversion to bytes and update the type for mem_limit and mem_reservation in comments.

Fix memory conversion to bytes
0faf6e3 
Signed-off-by: aiordache <anca.iordache@docker.com>
@aiordache aiordache requested a review from ulyssessouza August 17, 2020 15:23
update tests
6c081f2 
Signed-off-by: aiordache <anca.iordache@docker.com>
ulyssessouza
ulyssessouza approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@ulyssessouza ulyssessouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ulyssessouza ulyssessouza merged commit 2c522fb into docker:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@ulyssessouza ulyssessouza ulyssessouza approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ulyssessouza ulyssessouza

@aiordache aiordache

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiordache @ulyssessouza