Skip to content

Add coverage #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 21, 2014
Merged

Add coverage #269

merged 1 commit into from
Jul 21, 2014

Conversation

Aigeruth
Copy link
Contributor

@Aigeruth Aigeruth commented Jul 9, 2014

No description provided.

@shin-
Copy link
Contributor

shin- commented Jul 9, 2014

Oh cool! coverage seems to be confused by our python 2/3 shenanigans (e.g. every if six.PY3: line is marked as "partial"), is there any way to fix this? Otherwise LGTM =)

@Aigeruth
Copy link
Contributor Author

@shin- There is a solution for this problem. It is called combine. I will check it out and update the PR.

@Aigeruth
Copy link
Contributor Author

I've updated the PR. Coverage reports should be fine now.

@shin-
Copy link
Contributor

shin- commented Jul 21, 2014

Thanks! =)

shin- added a commit that referenced this pull request Jul 21, 2014
@shin-
Merge pull request #269 from Aigeruth/feature/coverage
d2f49a9 
Add coverage
@shin- shin- merged commit d2f49a9 into docker:master Jul 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Aigeruth @shin-