Restart Policy for Containers Implemented fixes #302 #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
docker/client.py
Outdated
There was a problem hiding this comment.
@shreyu86 Why the deprecation working?
There was a problem hiding this comment.
Because registry version below 1.0 does not support the restart flag, if I am wrong I can rip that out.
|
@shin- I will remove it. I was over thinking :) |
|
Thanks 👍 |
|
@discordianfish and @shin- added I can add a line or two in README.md for documenting this change is that OK? |
|
Sure go ahead! |
|
added documentation. |
|
Thanks! |
shin-
added a commit
that referenced
this pull request
Aug 28, 2014
Restart Policy for Containers Implemented fixes #302
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my attempt to fix #302 let me know if any modifications are needed, willing to comply to the repo standards and contribute.