Skip to content

fix create_host_config method #462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2015
Merged

fix create_host_config method #462

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions docker/utils/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,15 +337,15 @@ def create_host_config(
volumes_from = volumes_from.split(',')
host_config['VolumesFrom'] = volumes_from

if binds:
if binds is not None:
host_config['Binds'] = convert_volume_binds(binds)

if port_bindings:
if port_bindings is not None:
host_config['PortBindings'] = convert_port_bindings(
port_bindings
)

if extra_hosts:
if extra_hosts is not None:
if isinstance(extra_hosts, dict):
extra_hosts = [
'{0}:{1}'.format(k, v)
Expand All @@ -354,7 +354,7 @@ def create_host_config(

host_config['ExtraHosts'] = extra_hosts

if links:
if links is not None:
if isinstance(links, dict):
links = six.iteritems(links)

Expand All @@ -370,7 +370,7 @@ def create_host_config(
formatted.append({'Key': k, 'Value': str(v)})
lxc_conf = formatted

if lxc_conf:
if lxc_conf is not None:
host_config['LxcConf'] = lxc_conf

return host_config