Rename Client._timeout to timeout. #475
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Um, I think that's all fine. Regarding the Changelog, I usually compile it myself when doing a release, so don't worry about it :) |
shin-
added a commit
that referenced
this pull request
Feb 10, 2015
Rename Client._timeout to timeout.
|
I just realized that I renamed Would you accept another PR that renamed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #284 , here's a PR that renames Client._timeout to be public. This initial PR does not make any attempt to alias
_timeouttotimeout, but that's easily added if we want/need to do that.I wasn't sure what the policy was on documenting these changes. I'd be glad to add that to the change log as well if someone lets me know what version number we're shooting for next.