Add missing options to the events command #480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggtools
force-pushed
the
events
branch
4 times, most recently
from
36839d9 to
203e446
Compare
|
Hi, thanks for contributing! This looks good, my only issue is that, if I understand correctly, this would break for people currently using the events endpoint because of the different output format (strings VS dicts). Can we maybe add the decoding on the fly as an option, and leave the default as is to avoid breaking? Thanks! |
This was referenced Feb 10, 2015
Closed
|
Yes you're definitely right I adding this to the PR right now. |
- Add since, until and filters parameters to `Client.events` - Add missing `events`command in the documentation Signed-off-by: Christophe Labouisse <christophe@labouisse.org>
Signed-off-by: Christophe Labouisse <christophe@labouisse.org>
Signed-off-by: Christophe Labouisse <christophe@labouisse.org>
Signed-off-by: Christophe Labouisse <christophe@labouisse.org>
This will ensure compatibility with the previous versions of docker-py. Signed-off-by: Christophe Labouisse <christophe@labouisse.org>
|
Awesome, thanks! LGTM. |
shin-
added a commit
that referenced
this pull request
Feb 11, 2015
Add missing options to the events command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Client.eventseventscommand in the documentationSigned-off-by: Christophe Labouisse christophe@labouisse.org