Allow extra_hosts to be a list too #614
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/utils/utils.py
Outdated
There was a problem hiding this comment.
just extract that line from the inner block instead?
The current map syntax does not allow the API equivalent of
--add-host foo:1.1.1.1 --add-host foo:2.2.2.2
The above will map one hostname to two IPs. The above is valid in Docker.
ibuildthecloud
force-pushed
the
extra-host-list
branch
from
90e44e6 to
fb2b707
Compare
|
@shin Updated as per comment |
|
@shin Can this be merged now? |
|
Thanks! 👍 sorry about the delay. |
shin-
added a commit
that referenced
this pull request
Jun 18, 2015
Allow extra_hosts to be a list too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current map syntax does not allow the API equivalent of
The above will map one hostname to two IPs. The above is valid in Docker.