ClientBase extraction #652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unless you expect to have other subclasses of If readability of the |
|
I agree that the end goal should be to have most of those outside of the class, but I was considering this as a first step in separating API code from internal code. I strongly believe it's still better than the current state of the code and it's relatively low effort. |
shin-
force-pushed
the
clientbase_extraction
branch
from
0862265 to
abef716
Compare
shin-
force-pushed
the
clientbase_extraction
branch
from
abef716 to
4f89ca7
Compare
|
Alright, let's work from there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.