Prefer new Docker config location and format. #654
Conversation
|
@mpetazzoni Refactored a bit of that to avoid some duplication. Also allowed the provided config_path to override the default both for the old and new config locations. |
|
On a side note it'd be nice if we could give some feedback to the caller on whether any authentication was sent. Without this docker-compose is left to simply say that a repo wasn't found with no indication that it could be a simple authentication issue. |
docker/auth/auth.py
Outdated
There was a problem hiding this comment.
Could this be scoped to the specific type(s) of exception we're expecting?
|
@aanand I was aiming to follow the style later in the code for the legacy location where we're ignoring all exceptions but your point's totally valid. Will update. |
|
Just saw that line, yes - we should fix that too (in a separate PR). |
|
👍 LGTM. Might be worth squashing those together. |
This tries to load Docker authentication info from ~/.docker/config.json before falling back to its legacy location and format at ~/.dockercfg. Resolves docker#648
|
LGTM. Thanks! |
Prefer new Docker config location and format.
This tries to load Docker authentication info from
~/.docker/config.json before falling back to its legacy location and
format at ~/.dockercfg.
Resolves #648