fix premature EOF detection in streams #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docker engine may send empty chunks of data in the stream (especially since moby/moby#13033) They should not be taken for EOF Signed-off-by: Anthony Baire <Anthony.Baire@irisa.fr>
|
Is this similar to #631? |
|
It is a different issue. #631 deals with choosing the right reader This PR fixes a bug in the 'multiplexed' reader. |
|
Fixes #656 |
|
+1 |
|
LGTM |
|
The existence of this bug suggests a blindspot in integration testing, can we fix that? |
|
@thieman +1, actually |
|
Can we get this fix merged for 1.3.0 one way or the other? This is a serious problem for us. |
|
Sorry, it was too late to make the cut, but I'll look into having it in a patch version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docker engine may send empty chunks of data in the stream
(especially since moby/moby#13033)
They should not be taken for EOF
Signed-off-by: Anthony Baire Anthony.Baire@irisa.fr