return NotFound on 404 errors #676
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes raises docker.errors.NotFound on 404 errors. This gives
client code the ability to differentiate between "an image does not
exist" and "you are using the api incorrectly".
This inherits from docker.errors.APIError so it will not affect any
existing code.
The particular case I am trying to address is client code that does something like this:
It really only makes sense to retry the create operation if the image
was not found; any other API error will simply fail the second time as
well.