Switch to send full AuthConfig object for build action #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support the docker API for version 1.7+, this command changes the way the `X-Registry-Config` header is sent when attempting to build an image.
|
I created #682 based off of this, with a change to support older versions of the API / Docker daemon. Feel free to review it! I will close this PR in favor of the new one as a result, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support the docker API for version 1.7+, this command
changes the way the
X-Registry-Configheader is sent when attemptingto build an image.
This fixes an issue I've experienced when using
docker-composeand buildingan image which is based off of a private image hosted at Docker Hub. I don't believe
this change is backwards compatible, and I'm not familiar enough with python to
have a solution for that. I'd appreciate some help if that is necessary.
Here's the commit on the Docker project where they changed the way the AuthConfig
objects were being parsed for the build API endpoint.