Enforce UTC datetimes in arguments to events()
#680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/utils/utils.py
Outdated
There was a problem hiding this comment.
This is going to break if the dt parameter is unspecified. Not that it ever should - I say we remove the default value altogether, what do you think?
There was a problem hiding this comment.
For some reason I thought that's what I did, but it clearly isn't. Updated.
aanand
force-pushed
the
fix-timestamp-conversion
branch
from
73e283f to
657420a
Compare
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
|
Thanks, lgtm! |
shin-
added a commit
that referenced
this pull request
Jul 21, 2015
Enforce UTC datetimes in arguments to `events()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't make the test suite pass on a machine that's not set to UTC, because the
datetime_to_timestamp()utility function performs date arithmetic under that assumption, causing one of theevents()tests to fail.I've changed it so that it always expects a UTC datetime, and made sure we pass one in in the test.
I also removed the default value for its argument, because (a) it wasn't used anywhere and (b) it was being set to to
datetime.now()at file load time, which almost certainly isn't what the user wants.