Change minimum API version for exec_inspect #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
To avoid confusion with the other |
|
You're right, it could definitely cause confusion. I've updated the error message. |
zubron
force-pushed
the
exec_inspect_version
branch
from
99a5461 to
7ba8332
Compare
|
Thanks! |
shin-
added a commit
that referenced
this pull request
Aug 24, 2015
Change minimum API version for exec_inspect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the minimum API version required for
exec_inspectcall. The current implementation tests against API version 1.15.The HTTP call that is used by
exec_inspectwas added to API version 1.16 which was introduced in Docker 1.4.0 moby/moby@00c2a8f.exec_inspectcan be found in the documentation for version 1.16 (https://docs.docker.com/reference/api/docker_remote_api_v1.16/#exec-inspect) but does not appear in the documentation for version 1.15 (https://docs.docker.com/reference/api/docker_remote_api_v1.15/).The other
execfunctions were introduced in API version 1.15 and are correct.