Integration test improvements #747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aanand
commented
Aug 27, 2015
aanand
commented
- Fix the setup step (the process has changed now that we're using pytest)
- Skip tests that are unstable
- Make better use of build caching
This was referenced Aug 27, 2015
Closed
tests/integration_test.py
Outdated
There was a problem hiding this comment.
Why are we using a list to store a single value? Am I missing something?
There was a problem hiding this comment.
A hack caused by my misunderstanding of what features existed in Python 2 and 3. Updated to use global.
- Fix the setup step (the process has changed now that we're using pytest) - Skip tests that are unstable - Make better use of build caching Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
aanand
force-pushed
the
integration-test-fixes
branch
from
1088b8d to
6c0f718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.