Skip to content

Fix bind volume from host with Unicode path #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix bind volume from host with Unicode path #774

wants to merge 2 commits into from

Conversation

ColinHuang
Copy link
Contributor

If the binds key is unicode. It will occurs exception as following:

  File "/home/vagrant/.local/share/virtualenvs/qnap/local/lib/python2.7/site-packages/docker/utils/utils.py", line 461, in create_host_config
    host_config['Binds'] = convert_volume_binds(binds)
  File "/home/vagrant/.local/share/virtualenvs/qnap/local/lib/python2.7/site-packages/docker/utils/utils.py", line 208, in convert_volume_binds
    k, v['bind'], mode

@shin-
Merge pull request #768 from ColinHuang/master
bd6a79f 
Remove not exists file in MANIFEST.in
@ColinHuang
Fix bind volume from host with unicode path
9b54f73 
Signed-off-by: Colin Huang <sidawei@gmail.com>
@ColinHuang ColinHuang changed the title Fix bind volume from host with unicode path Fix bind volume from host with Unicode path Sep 18, 2015
@ColinHuang ColinHuang mentioned this pull request Sep 22, 2015
Closed
@shin-
Copy link
Contributor

shin- commented Sep 24, 2015

Closing in favor of #787

@shin- shin- closed this Sep 24, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status/0-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ColinHuang @shin- @GordonTheTurtle