Add support for non-stream stats of containers #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akalipetis
changed the title
|
Thanks for contributing! This could use an integration test, otherwise LGTM. |
Adds one more flag to the `stats` method for streaming responses. Keeps default as streamed response for backwards compatibility. Signed-off-by: Antonis Kalipetis <akalipetis@gmail.com>
Signed-off-by: Antonis Kalipetis <akalipetis@gmail.com>
Signed-off-by: Antonis Kalipetis <akalipetis@gmail.com>
Also, fix typo in non-streaming stats. Signed-off-by: Antonis Kalipetis <akalipetis@gmail.com>
Signed-off-by: Antonis Kalipetis <akalipetis@gmail.com>
akalipetis
force-pushed
the
enhancement/stats-no-stream
branch
from
2b1d94a to
7e2ec1a
Compare
|
Added tests, rebased with master and 🎁 added an .editorconfig file to the repo. |
|
Thanks! |
|
This is really helpful, but can you guys merge it into the master branch pls? |
|
LGTM |
dnephin
added a commit
that referenced
this pull request
Nov 17, 2015
Add support for non-stream stats of containers
|
@dnephin Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds one more flag to the
statsmethod for non-streaming responses.Keeps default as streamed response for backwards compatibility.