Skip to content

Conversation

alasdairnicol
Copy link
Contributor

A couple of minor tidy ups to the examples in the docs, which make them more consistent, and avoid deprecation warnings.

@alasdairnicol
Copy link
Contributor Author

My initial patch was wrong, because create_host_config is a regular method, not a classmethod. I've fixed the patch and pushed it again.

@shin-
Copy link
Contributor

shin- commented Oct 14, 2015

Thanks! Can you squash those into one single commit?

On a tangential note, I'm not the biggest fan of calling the client instance cli because of the "Command Line Interface" acronym. But we can take another pass at this later - it being consistent means it's easier to sed later down the line.

@shin- shin- added this to the 1.6.0 milestone Oct 14, 2015
 * Use `cli = Client` everywhere
 * Use Client.create_host_config method
 * Added missing '>'s

Signed-off-by: Alasdair Nicol <alasdair@thenicols.net>
@alasdairnicol
Copy link
Contributor Author

Thanks for the quick review! I've squashed into a single commit and rebased.

I'm not the biggest fan of calling the client instance cli because of the "Command Line Interface" acronym.

Sure, I understand. I chose cli because it appeared to be the most common variable name, not for any other reason.

@shin-
Copy link
Contributor

shin- commented Oct 14, 2015

LGTM, thanks!

@dnephin
Copy link
Contributor

dnephin commented Oct 15, 2015

LGTM

dnephin added a commit that referenced this pull request Oct 15, 2015
@dnephin dnephin merged commit c698674 into docker:master Oct 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants