allow custom ipam options when creating networks #818
Conversation
rmb938
force-pushed
the
patch-1
branch
3 times, most recently
from
d2b0ea2 to
6608427
Compare
docker/api/network.py
Outdated
There was a problem hiding this comment.
Since this doesn't need to exist inside the Client (doesn't use self), I think it should be moved to a function inside the docker.utils module instead.
There was a problem hiding this comment.
That makes sense, moving it now.
There was a problem hiding this comment.
Also, it would be nice to have it renamed to create_ipam_config to be consistent with the currently existing create_host_config and create_container_config. 😄
|
Thanks for contributing! I'm going to wait for the 1.9.0 release to merge this to make sure things don't change last minute. In the meantime, having some tests and mentioning the added methods in the documentation would be a valuable improvement. |
|
Sounds good. Will start working on those. |
|
Hi @rmb938 , do you mind rebasing this? We can take a closer look now that 1.9 is out. |
|
@shin- Yup no problem. Sorry for the late reply I will get it done this weekend. |
|
@shin- sorry for the delay. I got everything rebased. if it all looks good I can squash all the commits for you. |
docker/utils/utils.py
Outdated
There was a problem hiding this comment.
pool_configs or [] would allow us to get rid of the first two lines here. Small readability improvement.
|
Thanks for updating. A few things to change in the docs and a small nitpick in the Feel free to squash it as well :) |
Signed-off-by: Ryan Belgrave <rmb1993@gmail.com>
|
@shin- how does that look |
|
Thanks, looking great - LGTM! |
|
LGTM |
allow custom ipam options when creating networks
4 participants
This addresses issue #815
These options are currently not documented but are still useful when creating networks.