840 add exception utility method for create host config #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
docker/utils/utils.py
Outdated
There was a problem hiding this comment.
I think these should be args, not kwargs, since they are both required.
Same for host_config_type_error
|
I like it, left some comments |
lots0logs
force-pushed
the
840-add-exception-utility-method-for-create-host-config
branch
6 times, most recently
from
38c78eb to
fc3c829
Compare
lots0logs
force-pushed
the
840-add-exception-utility-method-for-create-host-config
branch
from
707af12 to
0610e9e
Compare
|
LGTM |
|
LGTM, but I think it needs a rebase. It might be that the gihub "branch protection" is preventing me from merging this because I'm not an owner on this repo. |
lots0logs
force-pushed
the
840-add-exception-utility-method-for-create-host-config
branch
from
3a85868 to
d971993
Compare
Signed-off-by: Dustin Falgout <dustin@falgout.us>
Added tests for the new methods. Closes docker#840 Signed-off-by: Dustin Falgout <dustin@falgout.us>
lots0logs
force-pushed
the
840-add-exception-utility-method-for-create-host-config
branch
from
d971993 to
7638e0a
Compare
Signed-off-by: Dustin Falgout <dustin@falgout.us>
lots0logs
force-pushed
the
840-add-exception-utility-method-for-create-host-config
branch
from
7638e0a to
e0c6ec0
Compare
aanand
added a commit
that referenced
this pull request
Dec 4, 2015
…od-for-create-host-config 840 add exception utility method for create host config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #840