Move methods/classes used by all integration tests to helpers.py #855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests/helpers.py
Outdated
There was a problem hiding this comment.
I think if you use print(..., file=sys.stderr) with from __future__ import print_function you won't need the encoding.
shin-
force-pushed
the
852-independent-integration
branch
from
c89705d to
6878fc2
Compare
|
@dnephin Updated - should look better now. |
|
looks like there is one flake8 failure, otherwise LGTM |
Ensure setup_module is called at session level, making the test suite not order dependent. Test files can be invoked independently. Signed-off-by: Joffrey F <joffrey@docker.com>
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
852-independent-integration
branch
from
6878fc2 to
73b5140
Compare
shin-
added a commit
that referenced
this pull request
Nov 19, 2015
Move methods/classes used by all integration tests to helpers.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure setup_module is called in each file, making the test suite
not order dependent.
Fixes #852