Treat 'index.docker.io' repo names as 'docker.io' #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
The structure of the fake config dictionary was not reflective of what actual parsed config looks like. Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
Signed-off-by: Aanand Prasad <aanand.prasad@gmail.com>
|
Seems reasonable to me. Previously we weren't converting |
|
I'll try to check against the engine code base, I was in that part not too long ago for #861 |
|
@dnephin correct. |
|
Ok, I checked against the engine code (which I agree is a mess) and this looks to imitate the behavior properly. LGTM. |
aanand
added a commit
that referenced
this pull request
Dec 16, 2015
Treat 'index.docker.io' repo names as 'docker.io'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problem described in docker/compose#1622 (comment). Auth lookups were failing for private images specified as
docker.io/username/image.I'm still a bit unsure as to exactly how we're supposed to treat each type of key we encounter in an auth file (e.g. whether we're supposed to strip all URLs of scheme and path, or just special-case the Docker index). I had a go at reading the Docker client code but it's hard to follow. So I'm not 100% sure we're doing the right thing here.