Handle 64-bit integer values in parse_bytes #880
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is supporting decimal values important? The Docker CLI doesn't seem to do it: $ docker run -d -m=1.5G busybox true
docker: invalid size: '1.5G'.
See 'docker run --help'.I'd argue it's more important to keep in line with the CLI than to add conveniences. This being a library, consumers can do their own maths pretty easily if they need to. |
|
It's not imperative, but I don't see any downside to having the option be available! |
shin-
force-pushed
the
813-parse-float-bytes
branch
from
93211dd to
218a95f
Compare
Signed-off-by: Joffrey F <joffrey@docker.com>
shin-
force-pushed
the
813-parse-float-bytes
branch
from
218a95f to
cd66f6c
Compare
shin-
changed the title
shin-
added a commit
that referenced
this pull request
Jan 18, 2016
Handle 64-bit integer values in parse_bytes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also ensure we are able to handle 64-bit integers in py2
Fixes #813