-
Notifications
You must be signed in to change notification settings - Fork 1.7k
HttpHeaders support (similar to docker client) #886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docker/auth/auth.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line seems unnecessary.
Thanks for your contribution! I made a few comments, and the branch also needs to be rebased. |
Thanks for your review! |
LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this could use a new test case. I don't see anything asserting these are read properly.
Is this PR just missing a test to check HttpHeaders are read from the @kpavel Are you able to add this test? Would be great to get this PR merged. |
Signed-off-by: Pavel Kravchenko <kpavel@il.ibm.com> Fixed and refactored Signed-off-by: Pavel Kravchenko <kpavel@il.ibm.com>
Please sign your commits following these rules: $ git clone -b "autz" git@github.com:kpavel/docker-py-1.git somewhere
$ cd somewhere
$ git rebase -i HEAD~2
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f Ammending updates the existing PR. You DO NOT need to open a new one. |
Awesome work @kpavel! 👍 |
Closed via #899 - Thanks! |
Signed-off-by: Pavel Kravchenko kpavel@il.ibm.com
Docker client already supports HttpHeaders from config file.
https://docs.docker.com/v1.7/docker/reference/commandline/cli/
Leveraging existing configuration file support in python docker client added support for generic HttpHeaders.